Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 26, 2021

What does this PR do?

Addresses leftover comments in #7337
It may not be clear to the reader that Lightning by default defines a closure that it passes to the optimizer.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli force-pushed the docs/clarify-closure branch from 87d117b to 45c9eaa Compare July 26, 2021 08:15
@awaelchli awaelchli added the docs Documentation related label Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #8551 (5762b14) into master (6dbdf43) will decrease coverage by 3%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #8551     +/-   ##
========================================
- Coverage      92%     89%     -3%     
========================================
  Files         218     218             
  Lines       14405   17961   +3556     
========================================
+ Hits        13299   16002   +2703     
- Misses       1106    1959    +853     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli marked this pull request as ready for review July 26, 2021 13:25
@tchaton tchaton added the ready PRs ready to be merged label Jul 26, 2021
@mergify mergify bot requested a review from a team July 26, 2021 13:48
@awaelchli awaelchli enabled auto-merge (squash) July 26, 2021 14:00
@awaelchli awaelchli merged commit eaa16c7 into master Jul 26, 2021
@awaelchli awaelchli deleted the docs/clarify-closure branch July 26, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants