Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 16, 2021

What does this PR do?

This test for hpc_load deprecation was incorrectly placed in the file test_remove_1_4.py but should be in the 1.6 file.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #8446 (ef9861d) into master (374fae5) will increase coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8446    +/-   ##
=======================================
+ Coverage      89%     92%    +4%     
=======================================
  Files         217     217            
  Lines       14223   14223            
=======================================
+ Hits        12605   13128   +523     
+ Misses       1618    1095   -523     

@awaelchli awaelchli marked this pull request as ready for review July 16, 2021 17:21
@carmocca carmocca added the ready PRs ready to be merged label Jul 18, 2021
@justusschock justusschock enabled auto-merge (squash) July 19, 2021 07:22
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justusschock justusschock merged commit 999ef5c into master Jul 19, 2021
@justusschock justusschock deleted the tests/hpc_load_deprecation branch July 19, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants