Skip to content

Conversation

@carmocca
Copy link
Contributor

What does this PR do?

We forgot to mark these as protected. Follows the same pattern as in PredictionEpochLoop.

Does your PR introduce any breaking changes ? If yes, please list them.

Users relying on these will fail. But these should have been protected from the start. This is okay as the loop refactor is unreleased.

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.4 milestone Jul 14, 2021
@carmocca carmocca self-assigned this Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #8420 (8d30dc1) into master (74a09a2) will decrease coverage by 4%.
The diff coverage is 92%.

@@           Coverage Diff           @@
##           master   #8420    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         216     216            
  Lines       14112   14109     -3     
=======================================
- Hits        13017   12421   -596     
- Misses       1095    1688   +593     

@awaelchli awaelchli added the ready PRs ready to be merged label Jul 14, 2021
@mergify mergify bot requested a review from a team July 14, 2021 15:20
@carmocca carmocca requested review from Borda and SeanNaren as code owners July 14, 2021 17:20
@kaushikb11 kaushikb11 enabled auto-merge (squash) July 15, 2021 11:30
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kaushikb11 kaushikb11 merged commit 176df20 into master Jul 15, 2021
@kaushikb11 kaushikb11 deleted the refactor/loops-protected-attrs branch July 15, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants