Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 4, 2021

What does this PR do?

On master, we see the following warning when using a datamodule:

/Users/adrian/repositories/pytorch-lightning/pytorch_lightning/core/datamodule.py:167: LightningDeprecationWarning: DataModule property `has_prepared_data` was deprecated in v1.4 and will be removed in v1.6.

I believe the problem was introduced here #7657, but the warning wasn't shown for a while, cc @carmocca

Note: only in master, 1.3.x not affected. No changelog required.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Jul 4, 2021
@awaelchli awaelchli added this to the v1.4 milestone Jul 4, 2021
@codecov
Copy link

codecov bot commented Jul 4, 2021

Codecov Report

Merging #8271 (8c35b9c) into master (8193bae) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8271   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         212     212           
  Lines       13720   13720           
======================================
- Hits        12751   12684   -67     
- Misses        969    1036   +67     

@awaelchli awaelchli requested a review from carmocca July 4, 2021 09:56
@awaelchli awaelchli marked this pull request as ready for review July 4, 2021 10:22
@awaelchli awaelchli enabled auto-merge (squash) July 4, 2021 10:22
@awaelchli awaelchli added the ready PRs ready to be merged label Jul 4, 2021
@awaelchli awaelchli merged commit d7a0786 into master Jul 5, 2021
@awaelchli awaelchli deleted the bugfix/prepare-data-warning branch July 5, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants