-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Sync our torchmetrics wrappers after the 0.4 release #8205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Borda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the fix is a double wrapper which is switched according to TM version
https://github.com/Borda/pyDeprecate#conditional-skip
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #8205 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 212 212
Lines 13588 13588
======================================
- Hits 12613 12559 -54
- Misses 975 1029 +54 |
|
probably unrelated failer on Windows minimal |
I have a fix for this in #8199, but needs this PR first |
What does this PR do?
2 issues after the torchmetrics 0.4 release:
is_multi{class,label}was removed. We can also remove it because we pin the torchmetrics version. The deprecation process was done in torchmetrics.to_categoricalargument was renamed.Fixes the failing tests in master
There will be a separate fix for the bug-fix branch where we want to keep BC: #8206
Before submitting
PR review