Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Jun 29, 2021

What does this PR do?

2 issues after the torchmetrics 0.4 release:

  • is_multi{class,label} was removed. We can also remove it because we pin the torchmetrics version. The deprecation process was done in torchmetrics.
  • The to_categorical argument was renamed.

Fixes the failing tests in master
There will be a separate fix for the bug-fix branch where we want to keep BC: #8206

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working priority: 0 High priority task labels Jun 29, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 29, 2021
@carmocca carmocca self-assigned this Jun 29, 2021
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix is a double wrapper which is switched according to TM version
https://github.com/Borda/pyDeprecate#conditional-skip

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #8205 (14e9fdc) into master (9444a08) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8205   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         212     212           
  Lines       13588   13588           
======================================
- Hits        12613   12559   -54     
- Misses        975    1029   +54     

@Borda
Copy link
Collaborator

Borda commented Jun 29, 2021

probably unrelated failer on Windows minimal

>       if not torch_distrib.is_initialized():
E       AttributeError: module 'torch.distributed' has no attribute 'is_initialized'

@carmocca
Copy link
Contributor Author

probably unrelated failer on Windows minimal

>       if not torch_distrib.is_initialized():
E       AttributeError: module 'torch.distributed' has no attribute 'is_initialized'

I have a fix for this in #8199, but needs this PR first

@carmocca carmocca enabled auto-merge (squash) June 29, 2021 21:57
@carmocca carmocca merged commit 47c7654 into master Jun 29, 2021
@carmocca carmocca deleted the bugfix/fix-after-torchmetrics-0.4-release branch June 29, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: 0 High priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants