Skip to content

Conversation

@stancld
Copy link
Contributor

@stancld stancld commented Jun 25, 2021

What does this PR do?

Part of #7037. This PR disentangles large #7218. It fixes mypy typing in utilities.device_parser.py.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ready PRs ready to be merged label Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #8136 (8931b4c) into master (af52de1) will decrease coverage by 5%.
The diff coverage is 75%.

@@           Coverage Diff           @@
##           master   #8136    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         212     212            
  Lines       13701   13699     -2     
=======================================
- Hits        12741   12057   -684     
- Misses        960    1642   +682     

stancld added 2 commits June 30, 2021 10:19
* include carmocca's suggestion

* add `else` statement to `parse_gpu_ids` to inform mypy `gpus` is a type of `List[int]`
@pep8speaks
Copy link

pep8speaks commented Jul 1, 2021

Hello @stancld! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-01 21:56:40 UTC

@mergify mergify bot removed the has conflicts label Jul 1, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) July 6, 2021 08:39
@tchaton tchaton merged commit 34efadd into Lightning-AI:master Jul 6, 2021
@kaushikb11 kaushikb11 added this to the v1.4 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants