Skip to content

Conversation

@stancld
Copy link
Contributor

@stancld stancld commented Jun 25, 2021

What does this PR do?

Part of #7037. This PR disentangles large #7218. It fixes mypy typing in utilities.argparse.py.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@justusschock justusschock enabled auto-merge (squash) June 25, 2021 10:40
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #8124 (ef2fe36) into master (ba80534) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8124   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         168     168           
  Lines       13975   13981    +6     
======================================
+ Hits        12344   12350    +6     
  Misses       1631    1631           

@Borda Borda added the ready PRs ready to be merged label Jun 25, 2021
@Borda
Copy link
Collaborator

Borda commented Jun 25, 2021

pls add it also here https://github.com/PyTorchLightning/pytorch-lightning/blob/ad957108128776463470830b3a5f4ad89be23002/setup.cfg#L184-L185

auto-merge was automatically disabled June 25, 2021 15:07

Head branch was pushed to by a user without write access

@stale
Copy link

stale bot commented Jul 10, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added won't fix This will not be worked on and removed won't fix This will not be worked on labels Jul 10, 2021
@carmocca carmocca removed the ready PRs ready to be merged label Jul 12, 2021
@mergify mergify bot removed the has conflicts label Jul 13, 2021
@Borda Borda added the ready PRs ready to be merged label Jul 13, 2021
@tchaton tchaton enabled auto-merge (squash) July 21, 2021 10:07
@tchaton tchaton disabled auto-merge July 21, 2021 10:45
@tchaton tchaton enabled auto-merge (squash) July 21, 2021 10:52
@mergify mergify bot removed the has conflicts label Jul 27, 2021
@mergify mergify bot removed the has conflicts label Jul 30, 2021
@carmocca carmocca disabled auto-merge July 30, 2021 13:59
@carmocca carmocca enabled auto-merge (squash) July 30, 2021 13:59
@carmocca carmocca merged commit 1f01db8 into Lightning-AI:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants