-
Notifications
You must be signed in to change notification settings - Fork 3.6k
training loop refactor - move val loop #8120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
commented
Jun 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #8120 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 212 212
Lines 13549 13541 -8
=======================================
- Hits 12590 11897 -693
- Misses 959 1644 +685 |
7ab22e7 to
a5327b5
Compare
carmocca
approved these changes
Jun 24, 2021
11 tasks
justusschock
approved these changes
Jun 26, 2021
Borda
approved these changes
Jun 26, 2021
for more information, see https://pre-commit.ci
838f5f2 to
ca4664f
Compare
tchaton
approved these changes
Jun 29, 2021
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We currently have the validation loop owned by the fit loop, i.e.,
trainer.fit_loop.val_loop: EvaluationLoopIt was introduced there in #8065.
However, the validation loop is never used in the fit loop. It is called only in the epoch loop, i.e.
trainer.fit_loop.epoch_loopcalls the validation loop at the right interval. This PR moves the val loopfrom
trainer.fit_loop.val_looptotrainer.fit_loop.epoch_loop.val_loopThis does not require a changelog entry, since we are developing these loops on master only at the moment.
Discussed with @tchaton and @carmocca so far.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃