Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jun 12, 2021

What does this PR do?

fixing if any req was followed by comment it was not recognised

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working ci Continuous Integration labels Jun 12, 2021
@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #7958 (ac19e17) into master (22d8266) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7958   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         203     203           
  Lines       13127   13127           
======================================
- Hits        12013   11975   -38     
- Misses       1114    1152   +38     

Co-authored-by: Carlos Mocholí <[email protected]>
@Borda Borda enabled auto-merge (squash) June 13, 2021 16:29
@Borda Borda requested a review from carmocca June 13, 2021 16:29
@Borda Borda added the ready PRs ready to be merged label Jun 13, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@Borda Borda merged commit cca0e75 into master Jun 14, 2021
@Borda Borda deleted the ci/versions branch June 14, 2021 14:24
@carmocca carmocca mentioned this pull request Jun 15, 2021
carmocca added a commit that referenced this pull request Jun 15, 2021
* remove parsing comments
* \s

Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Jun 17, 2021
* remove parsing comments
* \s

Co-authored-by: Carlos Mocholí <[email protected]>
@carmocca carmocca added this to the v1.3.x milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants