Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented May 24, 2021

What does this PR do?

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label May 24, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #7676 (ea3e762) into master (8b01497) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7676   +/-   ##
======================================
- Coverage      93%     92%   -0%     
======================================
  Files         199     199           
  Lines       12957   12957           
======================================
- Hits        11991   11950   -41     
- Misses        966    1007   +41     

@Borda Borda enabled auto-merge (squash) May 24, 2021 13:44
@Borda Borda added the ready PRs ready to be merged label May 24, 2021
@Borda Borda force-pushed the docs/chlog-1.3.2 branch from 19a1dff to ea3e762 Compare May 24, 2021 17:25
@mergify mergify bot removed the has conflicts label May 24, 2021
@Borda Borda merged commit ad168fc into master May 24, 2021
@Borda Borda deleted the docs/chlog-1.3.2 branch May 24, 2021 17:55
@Borda Borda mentioned this pull request May 25, 2021
@awaelchli awaelchli added this to the v1.4 milestone May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants