Skip to content

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented May 20, 2021

What does this PR do?

This code wasn't using fsspec meaning remote filepaths (azure, s3, gcs) weren't supported out of the box. This PR fixes that by using fsspec, similar to how we use this in other parts of the codebase..

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #7617 (b41fcf9) into master (608de6a) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7617    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         197     198     +1     
  Lines       12871   12937    +66     
=======================================
- Hits        11871   11375   -496     
- Misses       1000    1562   +562     

@ananthsub ananthsub added the feature Is an improvement or enhancement label May 20, 2021
@ananthsub ananthsub added this to the v1.4 milestone May 20, 2021
@ananthsub ananthsub enabled auto-merge (squash) May 20, 2021 13:43
@ananthsub
Copy link
Contributor Author

@carmocca @tchaton @Borda mind taking a look when you get a chance?

Comment on lines 147 to 148
_DUMMY_PRFEIX = "dummy"
_PREFIX_SEPARATOR = "://"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these set as variables (instead of hardcoded) for a reason? Do you expect that other tests would need to modify them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think a dummy custom filesystem could be helpful to ensure fsspec works as expected, but this is not the right spot to land this. for now, i will move it into the test. i initially avoided putting this into the test to avoid registering the filesysem 3 times

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ananthsub ananthsub merged commit f6d892a into Lightning-AI:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Is an improvement or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants