Skip to content

Conversation

@carmocca
Copy link
Contributor

What does this PR do?

Pruning old code

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added ci Continuous Integration refactor labels May 20, 2021
@carmocca carmocca added this to the v1.4 milestone May 20, 2021
@carmocca carmocca self-assigned this May 20, 2021
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #7615 (670f5dd) into master (8266b14) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7615    +/-   ##
=======================================
- Coverage      92%     88%    -5%     
=======================================
  Files         198     198            
  Lines       12930   12803   -127     
=======================================
- Hits        11955   11245   -710     
- Misses        975    1558   +583     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda enabled auto-merge (squash) May 21, 2021 11:08
@Borda Borda merged commit e16d4fb into master May 21, 2021
@Borda Borda deleted the refactor/ci-code-cleaning branch May 21, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants