Skip to content

Conversation

@loic-beheshti
Copy link
Contributor

@loic-beheshti loic-beheshti commented May 14, 2021

Much better with a comma :)

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Much better with a comma :)
@awaelchli awaelchli enabled auto-merge (squash) May 15, 2021 00:09
@awaelchli awaelchli added the docs Documentation related label May 15, 2021
@awaelchli awaelchli added this to the v1.4 milestone May 15, 2021
@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #7554 (87914b3) into master (6ac16ff) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7554   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         196     196           
  Lines       12835   12835           
======================================
- Hits        11286   11270   -16     
- Misses       1549    1565   +16     

@awaelchli awaelchli merged commit e126649 into Lightning-AI:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants