Pin Sphinx<4.0
#7456
Merged
Pin Sphinx<4.0
#7456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
added
bug
akihironitta
requested review from
SeanNaren,
awaelchli,
carmocca,
justusschock,
kaushikb11,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7456 +/- ##
======================================
- Coverage 92% 92% -0%
======================================
Files 199 199
Lines 13030 13030
======================================
- Hits 11989 11951 -38
- Misses 1041 1079 +38 |
Borda
approved these changes
May 9, 2021
Borda
reviewed
May 9, 2021
requirements/docs.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| sphinx>=3.0, !=3.5 # fails with sphinx.ext.viewcode | |||
| sphinx>=3.0, !=3.5, <4.0 # fails with sphinx.ext.viewcode # fails with sphinx_paramlinks with 4.0.0 | |||
Collaborator
There was a problem hiding this comment.
There was no other release between 3.5 and 4.0
Contributor
Author
There was a problem hiding this comment.
I was wondering why it was using 3.5.4 in the very last successful runs even though we specified !=3.5:
Sphinx 3.5.4
https://github.com/PyTorchLightning/pytorch-lightning/runs/2535513652
awaelchli
approved these changes
May 10, 2021
Contributor
awaelchli
left a comment
awaelchli
left a comment
There was a problem hiding this comment.
need to wait for a sphinx-paramlinks update like last time :)
Closed
Borda
added a commit
that referenced
this pull request
May 11, 2021
* Dont use sphinx 4.0.0 * Dont use sphinx 4.0.0 * Update comment * Simple There is no other release between 3.5 and 4.0 Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 6d82dc8)
Borda
added a commit
that referenced
this pull request
May 11, 2021
* Dont use sphinx 4.0.0 * Dont use sphinx 4.0.0 * Update comment * Simple There is no other release between 3.5 and 4.0 Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 6d82dc8)
Borda
added a commit
that referenced
this pull request
May 11, 2021
* Dont use sphinx 4.0.0 * Dont use sphinx 4.0.0 * Update comment * Simple There is no other release between 3.5 and 4.0 Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 6d82dc8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7455.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃