Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented May 6, 2021

What does this PR do?

version++ and other cleaning

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label May 6, 2021
@Borda Borda added this to the v1.3 milestone May 6, 2021
# os: [ubuntu-20.04]
python-version: [3.7]
pytorch-version: [1.4, 1.5, 1.6, 1.7, 1.8, 1.9]
pytorch-version: [1.4, 1.5, 1.6, 1.7, 1.8] # todo: add back 1.9
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just to have green badges or #7396 is fixed

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #7404 (a9dc306) into master (d52e0a8) will decrease coverage by 0%.
The diff coverage is 50%.

@@          Coverage Diff           @@
##           master   #7404   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         200     200           
  Lines       12982   12983    +1     
======================================
- Hits        11911   11897   -14     
- Misses       1071    1086   +15     

# os: [ubuntu-20.04]
python-version: [3.7]
pytorch-version: [1.4, 1.5, 1.6, 1.7, 1.8, 1.9]
pytorch-version: [1.4, 1.5, 1.6, 1.7, 1.8] # todo: add back 1.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you know about it
#7396

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Borda Borda enabled auto-merge (squash) May 6, 2021 13:26
@leezu
Copy link
Contributor

leezu commented May 6, 2021

@Borda should #7362 be merged before the release?

@lexierule lexierule disabled auto-merge May 6, 2021 19:05
@lexierule lexierule merged commit b181b8c into master May 6, 2021
@lexierule lexierule deleted the r1.3.0 branch May 6, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants