Skip to content

Conversation

@kragniz
Copy link
Contributor

@kragniz kragniz commented May 5, 2021

What does this PR do?

Otherwise it's possible to get an incompatible version of torchtext.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kragniz kragniz requested review from Borda, carmocca and tchaton as code owners May 5, 2021 16:10
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #7383 (193b7d5) into master (f9ff354) will decrease coverage by 4%.
The diff coverage is 100%.

❗ Current head 193b7d5 differs from pull request most recent head 859c66b. Consider uploading reports for the commit 859c66b to get more accurate results

@@           Coverage Diff           @@
##           master   #7383    +/-   ##
=======================================
- Coverage      92%     87%    -4%     
=======================================
  Files         200     200            
  Lines       12953   12988    +35     
=======================================
- Hits        11880   11363   -517     
- Misses       1073    1625   +552     

@kragniz kragniz force-pushed the adjust-versions-for-ipu branch 2 times, most recently from 1ef5686 to f158cb2 Compare May 5, 2021 16:45
@kragniz kragniz force-pushed the adjust-versions-for-ipu branch from f158cb2 to 8b3b0ff Compare May 5, 2021 17:03
@Borda Borda added the ci Continuous Integration label May 5, 2021
@Borda Borda enabled auto-merge (squash) May 5, 2021 17:10
@Borda
Copy link
Collaborator

Borda commented May 5, 2021

lets skip also FAILED tests/models/test_horovod.py::test_horovod_cpu as it is not applicable for IPU, right?

auto-merge was automatically disabled May 5, 2021 17:56

Head branch was pushed to by a user without write access

@kragniz kragniz force-pushed the adjust-versions-for-ipu branch from 193b7d5 to 23a0ff9 Compare May 5, 2021 17:56
@kragniz kragniz force-pushed the adjust-versions-for-ipu branch from 23a0ff9 to 859c66b Compare May 5, 2021 18:45
@Borda Borda added the bug Something isn't working label May 5, 2021
@Borda Borda enabled auto-merge (squash) May 6, 2021 08:50
@Borda Borda added the ready PRs ready to be merged label May 6, 2021
@Borda Borda added this to the v1.3 milestone May 6, 2021
@Borda Borda merged commit 1a62f7f into Lightning-AI:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants