-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update DeepSpeed version requirement in Dockerfile #7326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @awaelchli! Thanks for opening this PR.
Do see the Hitchhiker's guide to code style |
Codecov Report
@@ Coverage Diff @@
## master #7326 +/- ##
=======================================
+ Coverage 87% 90% +3%
=======================================
Files 200 200
Lines 12865 13051 +186
=======================================
+ Hits 11210 11739 +529
+ Misses 1655 1312 -343 |
e0dd14b to
746928f
Compare
|
@awaelchli is there a tracking issue or other resource detailing the problems with deepspeed>0.3.14? |
|
Yes, a failing test after Deepspeed updated to a new version |
Co-authored-by: Carlos Mocholí <[email protected]>
What does this PR do?
Fixes PR merge blocking on master.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃