Skip to content

Conversation

@ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Apr 28, 2021

What does this PR do?

Fixes a bug which could occur if the line from pytorch_lightning import __about__ triggers something other than an ImportError. Was observed in flash, see here: Lightning-Universe/lightning-flash#247

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [N/A] Did you make sure to update the documentation with your changes? (if necessary)
  • [N/A] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [N/A] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #7256 (3a3a9fa) into master (0c6c078) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7256    +/-   ##
=======================================
  Coverage      91%     92%            
=======================================
  Files         199     199            
  Lines       12786   13252   +466     
=======================================
+ Hits        11665   12145   +480     
+ Misses       1121    1107    -14     

@Borda Borda added the bug Something isn't working label Apr 28, 2021
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets fix it also in docs/config

@ethanwharris ethanwharris requested a review from awaelchli as a code owner April 28, 2021 15:32
@ethanwharris
Copy link
Member Author

@Borda Done 😃

@Borda Borda enabled auto-merge (squash) April 28, 2021 19:39
@Borda Borda added the ready PRs ready to be merged label Apr 28, 2021
@Borda Borda merged commit 7a48db5 into master Apr 28, 2021
@Borda Borda deleted the fix/setup branch April 28, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants