Consistency in ModelCheckpoint verbose mode logs #7244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When using ModelCheckpoint in verbose mode, there are two different logs that you can get :
Epoch 1, step 100: val_loss was not in top 1Epoch 1, global step 100: val_loss was not in top 1In the first case, the
globalkeyword is missing, and it can be quite confusing.I was stuck for some time as I was trying to figure out why I had the following output:
I believed that each epoch the callback was looking at a specific step for the validation loss.
Adding the word
globalmakes it consistent with the message displayed if the model has improved.I did not open an issue, as it's a simple fix.
Did you have fun?
Make sure you had fun coding 🙃