Skip to content

_launch refactor and types [1/n] #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 28, 2021
Merged

_launch refactor and types [1/n] #7232

merged 9 commits into from
Apr 28, 2021

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Apr 27, 2021 •
edited
Loading

What does this PR do?

Fixes #7242

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working refactor labels Apr 27, 2021
@carmocca carmocca added this to the v1.3 milestone Apr 27, 2021
@carmocca carmocca self-assigned this Apr 27, 2021
@carmocca carmocca changed the title _fit_impl refactor and types _fit_impl refactor and types [1/n] Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #7232 (69e7537) into master (e147127) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7232    +/-   ##
=======================================
- Coverage      91%     90%    -2%     
=======================================
  Files         198     199     +1     
  Lines       12725   13216   +491     
=======================================
+ Hits        11633   11859   +226     
- Misses       1092    1357   +265

@mergify mergify bot removed the has conflicts label Apr 27, 2021
@carmocca carmocca mentioned this pull request Apr 27, 2021
Merged
11 tasks
@carmocca carmocca requested a review from awaelchli April 27, 2021 13:52
@carmocca carmocca mentioned this pull request Apr 27, 2021
Merged
9 tasks
ananthsub
ananthsub approved these changes Apr 27, 2021
View reviewed changes
@ananthsub ananthsub mentioned this pull request Apr 27, 2021
Closed
awaelchli
awaelchli approved these changes Apr 28, 2021
View reviewed changes
pytorch_lightning/trainer/trainer.py
# prevents sanity check to affect random sampling in training
reset_seed()

def fit(
Copy link
Contributor

@awaelchli awaelchli Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want to move this up? It would be nice if the entry points fit, validate, test came first.

Copy link
Contributor

@tchaton tchaton Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Let's try to organise, so it is simple to follow.

Copy link
Contributor Author

@carmocca carmocca Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this in a separate PR. Keeping them where they are for now so they are together

tchaton
tchaton reviewed Apr 28, 2021
View reviewed changes
pytorch_lightning/trainer/trainer.py
# prevents sanity check to affect random sampling in training
reset_seed()

def fit(
Copy link
Contributor

@tchaton tchaton Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Let's try to organise, so it is simple to follow.

@carmocca carmocca changed the title _fit_impl refactor and types [1/n] _launch refactor and types [1/n] Apr 28, 2021
tchaton
tchaton approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@pep8speaks
Copy link

pep8speaks commented Apr 28, 2021 •
edited
Loading

Hello @carmocca! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-28 14:36:20 UTC

@carmocca carmocca enabled auto-merge (squash) April 28, 2021 14:48
@carmocca carmocca added the ready PRs ready to be merged label Apr 28, 2021
@tchaton tchaton disabled auto-merge April 28, 2021 14:53
@carmocca carmocca merged commit bdc4272 into master Apr 28, 2021
@carmocca carmocca deleted the use-fit-impl branch April 28, 2021 15:41
ananthsub
ananthsub reviewed Apr 28, 2021
View reviewed changes
pytorch_lightning/trainer/trainer.py
self.on_init_end()

def fit(
def _launch(
Copy link
Contributor

@ananthsub ananthsub Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit : I prefer _run or _execute vs launch, which I associate more with distributed launch/process creation

Copy link
Contributor Author

@carmocca carmocca Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit late as it is already merged, but if you want to open a PR with the renaming change, that's fine by me! 👍

@awaelchli awaelchli mentioned this pull request Apr 28, 2021
Merged
11 tasks
@ananthsub ananthsub mentioned this pull request Apr 29, 2021
Merged
8 tasks
@carmocca carmocca mentioned this pull request Apr 30, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+2 more reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

bug Something isn't working ready PRs ready to be merged refactor

Projects

None yet

Milestone

pl:1.3

Development

Successfully merging this pull request may close these issues.

[Trainer] Use name mangling to allow for subclassing

5 participants

@carmocca @pep8speaks @ananthsub @awaelchli @tchaton