Skip to content

Conversation

@carmocca
Copy link
Contributor

What does this PR do?

Adding back this argument, which was mistakenly removed in #7022 as it's necessary for FSDP.
The argument is currently unused.

It is not necessary for TPUAccelerator

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the bug Something isn't working label Apr 27, 2021
@carmocca carmocca added this to the v1.3 milestone Apr 27, 2021
@carmocca carmocca self-assigned this Apr 27, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) April 27, 2021 11:04
@kaushikb11 kaushikb11 merged commit ca6c87f into master Apr 27, 2021
@kaushikb11 kaushikb11 deleted the clip-gradients-model-arg branch April 27, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants