Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Apr 19, 2021

What does this PR do?

c.f title.

Fixes #6927

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added this to the v1.3 milestone Apr 19, 2021
@tchaton tchaton requested a review from awaelchli as a code owner April 19, 2021 18:54
@tchaton tchaton self-assigned this Apr 19, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #7108 (be3a5b9) into master (3cc0b2c) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7108    +/-   ##
=======================================
- Coverage      92%     90%    -2%     
=======================================
  Files         197     197            
  Lines       12634   12982   +348     
=======================================
+ Hits        11649   11697    +48     
- Misses        985    1285   +300     

@Borda Borda added the bug Something isn't working label Apr 19, 2021
"""A contextmanager for the trainstep"""
torch.set_default_tensor_type(torch.DoubleTensor)
yield
torch.set_default_tensor_type(torch.FloatTensor)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall you rather save what was it before and then set it back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be fine. Didn't find any utils to get the default either.

@tchaton tchaton enabled auto-merge (squash) April 20, 2021 12:47
@tchaton tchaton merged commit 0137564 into master Apr 20, 2021
@tchaton tchaton deleted the force_default_type branch April 20, 2021 15:25
Comment on lines +105 to +108
train_step_context = tensor_type_context
val_step_context = tensor_type_context
test_step_context = tensor_type_context
predict_step_context = tensor_type_context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaton this is breaking the plugin typechecks with mypy:

pytorch_lightning/plugins/precision/double.py:105: error: Incompatible types in assignment (expression has type "Callable[[], _GeneratorContextManager[Any]]", base class "Plugin" defined the type as "Callable[[], Generator[Any, Any, Any]]")  [assignment]
pytorch_lightning/plugins/precision/double.py:106: error: Incompatible types in assignment (expression has type "Callable[[], _GeneratorContextManager[Any]]", base class "Plugin" defined the type as "Callable[[], Generator[Any, Any, Any]]")  [assignment]
pytorch_lightning/plugins/precision/double.py:107: error: Incompatible types in assignment (expression has type "Callable[[], _GeneratorContextManager[Any]]", base class "Plugin" defined the type as "Callable[[], Generator[Any, Any, Any]]")  [assignment]
pytorch_lightning/plugins/precision/double.py:108: error: Incompatible types in assignment (expression has type "Callable[[], _GeneratorContextManager[Any]]", base class "Plugin" defined the type as "Callable[[], Generator[Any, Any, Any]]")  [assignment]

rather than overriding these step contexts, could we share the same implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New tensors created are float32 when using precision=64

6 participants