Add typings for evaluation_loop.py and remove some dead code

[ethanwharris]

What does this PR do?

Docs

Before submitting

• [NA] Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• [NA] Did you make sure to update the documentation with your changes? (if necessary)
• [NA] Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• [NA] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #7015 (aa50dcb) into master (5bd3cd5) will increase coverage by 0%.
The diff coverage is 90%.

@@          Coverage Diff           @@
##           master   #7015   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         194     194           
  Lines       12415   12386   -29     
======================================
- Hits        11430   11414   -16     
+ Misses        985     972   -13     

[carmocca]

Can you run pre-commit?

pre-commit install
pre-commit run --all-files or pre-commit run (if changes are staged)

[ethanwharris]

@carmocca Have run pre-commit, many changes haha

[Borda]

if it is fine for the file, remove it from ignore list...

[pep8speaks]

Hello @ethanwharris! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-15 07:02:14 UTC

[tchaton]

Awesome work !