Skip to content

Conversation

@adityashukzy
Copy link
Contributor

@adityashukzy adityashukzy commented Apr 12, 2021

Changing "defined" to "defines" in keeping with the convention of using present tense in comments.

What does this PR do?

Fixes word tense; increases clarity. Changed "defined" to "defines" in keeping with the convention of present tense while writing comments in code.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃
I did have fun. :)

Changing "defined" to "defines" in keeping with the convention of using present tense in comments.
@Borda Borda added the docs Documentation related label Apr 12, 2021
@Borda Borda enabled auto-merge (squash) April 12, 2021 20:11
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #6974 (98d4797) into master (6c01608) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6974    +/-   ##
=======================================
- Coverage      92%     86%    -5%     
=======================================
  Files         194     194            
  Lines       12368   12368            
=======================================
- Hits        11324   10697   -627     
- Misses       1044    1671   +627     

@carmocca carmocca added this to the 1.3 milestone Apr 12, 2021
@carmocca carmocca added the ready PRs ready to be merged label Apr 12, 2021
@Borda Borda merged commit 644e7aa into Lightning-AI:master Apr 13, 2021
@adityashukzy adityashukzy deleted the patch-2 branch April 14, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants