Skip to content

Conversation

@ozen
Copy link
Contributor

@ozen ozen commented Apr 12, 2021

Based on pytorch docs about dataloader length and iterable datasets.

What does this PR do?

Fixes #6966

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Based on pytorch docs about dataloader length and iterable datasets.
@pep8speaks
Copy link

pep8speaks commented Apr 12, 2021

Hello @ozen! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-13 00:05:21 UTC

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #6972 (1a82a09) into master (030b76b) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6972    +/-   ##
=======================================
- Coverage      92%     86%    -5%     
=======================================
  Files         194     194            
  Lines       12356   12385    +29     
=======================================
- Hits        11337   10706   -631     
- Misses       1019    1679   +660     

@carmocca carmocca added this to the 1.3 milestone Apr 12, 2021
@carmocca carmocca added the docs Documentation related label Apr 12, 2021
@awaelchli awaelchli added the ready PRs ready to be merged label Apr 12, 2021
@awaelchli awaelchli merged commit 6c01608 into Lightning-AI:master Apr 13, 2021
@SeanNaren SeanNaren mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-processing with IterableDataset Warning

5 participants