Skip to content

Conversation

@SeanNaren
Copy link
Contributor

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #6971 (900b186) into master (fe0d088) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6971    +/-   ##
=======================================
- Coverage      92%     87%    -4%     
=======================================
  Files         194     194            
  Lines       12346   12346            
=======================================
- Hits        11331   10781   -550     
- Misses       1015    1565   +550     

@SeanNaren SeanNaren mentioned this pull request Apr 12, 2021
11 tasks
@SeanNaren
Copy link
Contributor Author

Closing as this doesn't work

@SeanNaren SeanNaren closed this Apr 12, 2021
@SeanNaren SeanNaren deleted the fix/mac_2 branch April 12, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant