Skip to content

DeepSpeed ZeRO docs fixes #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2021
Merged

DeepSpeed ZeRO docs fixes #6870

merged 1 commit into from
Apr 7, 2021

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Apr 7, 2021

What does this PR do?

Some missed comments from #6752
Credit goes to @awaelchli

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the docs Documentation related label Apr 7, 2021
@carmocca carmocca added this to the 1.3 milestone Apr 7, 2021
@carmocca carmocca self-assigned this Apr 7, 2021
awaelchli
awaelchli approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

SeanNaren
SeanNaren approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks guys :)

@SeanNaren SeanNaren merged commit 19e67d1 into master Apr 7, 2021
@SeanNaren SeanNaren deleted the 6752-missed-comments branch April 7, 2021 15:57
@SeanNaren SeanNaren mentioned this pull request Apr 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

4 more reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

docs Documentation related

Projects

None yet

Milestone

pl:1.3

Development

Successfully merging this pull request may close these issues.

5 participants

@carmocca @ananthsub @awaelchli @SeanNaren @kaushikb11