Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 22, 2021

What does this PR do?

use always mocked MNIST for testing

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added example priority: 0 High priority task ci Continuous Integration labels Mar 22, 2021
@Borda Borda added this to the 1.2.x milestone Mar 22, 2021
@Borda Borda marked this pull request as ready for review March 22, 2021 15:42
@Borda Borda changed the title mock examples hotfix: mock examples Mar 22, 2021
@Borda Borda enabled auto-merge (squash) March 22, 2021 15:44
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Co-authored-by: Carlos Mocholí <[email protected]>
@Borda Borda merged commit e62c7c7 into master Mar 22, 2021
@Borda Borda deleted the ci/mock-examples branch March 22, 2021 16:49
@carmocca carmocca mentioned this pull request Mar 29, 2021
carmocca pushed a commit that referenced this pull request Mar 29, 2021
* mock examples

* drop from GA
Borda added a commit that referenced this pull request Mar 30, 2021
* mock examples

* drop from GA
lexierule pushed a commit that referenced this pull request Mar 30, 2021
* mock examples

* drop from GA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration example priority: 0 High priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants