Skip to content

fixing examples #6600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 20, 2021
Merged

fixing examples #6600

merged 8 commits into from
Mar 20, 2021

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 19, 2021 •
edited
Loading

What does this PR do?

fix failing CI on failing examples

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added example priority: 0 High priority task ci Continuous Integration labels Mar 19, 2021
@Borda Borda added this to the 1.2.x milestone Mar 19, 2021
@Borda Borda marked this pull request as ready for review March 20, 2021 01:10
@Borda Borda enabled auto-merge (squash) March 20, 2021 01:11
kaushikb11
kaushikb11 reviewed Mar 20, 2021
View reviewed changes
kaushikb11
kaushikb11 reviewed Mar 20, 2021
View reviewed changes
@Borda Borda added the ready PRs ready to be merged label Mar 20, 2021
@Borda Borda merged commit cb59039 into master Mar 20, 2021
@Borda Borda deleted the ci/azure branch March 20, 2021 18:59
@carmocca carmocca mentioned this pull request Mar 22, 2021
Closed
Borda added a commit that referenced this pull request Mar 23, 2021
@Borda
fixing examples (#6600)
b0eb41a 
* try Azure

* -e

* path

(cherry picked from commit cb59039)
Borda added a commit that referenced this pull request Mar 23, 2021
@Borda
fixing examples (#6600)
55dbbf6 
* try Azure

* -e

* path

(cherry picked from commit cb59039)
Borda added a commit that referenced this pull request Mar 23, 2021
@Borda
fixing examples (#6600)
5a4529a 
* try Azure

* -e

* path

(cherry picked from commit cb59039)
lexierule pushed a commit that referenced this pull request Mar 24, 2021
@Borda @lexierule
fixing examples (#6600)
4e133ab 
* try Azure

* -e

* path

(cherry picked from commit cb59039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@akihironitta akihironitta Awaiting requested review from akihironitta

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@s-rog s-rog Awaiting requested review from s-rog

+4 more reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci Continuous Integration example priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.2.x

Development

Successfully merging this pull request may close these issues.

6 participants

@Borda @ananthsub @awaelchli @tchaton @rohitgr7 @kaushikb11