Skip to content

[doc] Update Dict Train Loader doc. #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2021
Merged

[doc] Update Dict Train Loader doc. #6579

merged 2 commits into from
Mar 18, 2021

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Mar 18, 2021 •
edited
Loading

What does this PR do?

Fixes #6578

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the docs Documentation related label Mar 18, 2021
@tchaton tchaton added this to the 1.2.x milestone Mar 18, 2021
@tchaton tchaton self-assigned this Mar 18, 2021
justusschock
justusschock approved these changes Mar 18, 2021
View reviewed changes
@tchaton tchaton enabled auto-merge (squash) March 18, 2021 12:12
@tchaton tchaton merged commit 8853a36 into master Mar 18, 2021
@tchaton tchaton deleted the doc/6578 branch March 18, 2021 17:14
@carmocca carmocca mentioned this pull request Mar 22, 2021
Closed
Borda pushed a commit that referenced this pull request Mar 23, 2021
@tchaton @Borda
[doc] Update Dict Train Loader doc. (#6579)
caebaea 
* update doc

* update example

(cherry picked from commit 8853a36)
Borda pushed a commit that referenced this pull request Mar 23, 2021
@tchaton @Borda
[doc] Update Dict Train Loader doc. (#6579)
0003f66 
* update doc

* update example

(cherry picked from commit 8853a36)
lexierule pushed a commit that referenced this pull request Mar 24, 2021
@tchaton @lexierule
[doc] Update Dict Train Loader doc. (#6579)
b895dd9 
* update doc

* update example

(cherry picked from commit 8853a36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justusschock justusschock justusschock approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tchaton tchaton

Labels

docs Documentation related

Projects

None yet

Milestone

pl:1.2.x

Development

Successfully merging this pull request may close these issues.

Improve docs for multiple dataloaders

4 participants

@tchaton @awaelchli @SeanNaren @justusschock