fix deprecation wrapper & tests

[Borda]

What does this PR do?

the past version did not honor base default values and was not able to reset it...

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[pep8speaks]

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-16 23:59:10 UTC

[codecov]

Codecov Report

Merging #6553 (db285a0) into master (b190403) will decrease coverage by 2%.
The diff coverage is 100%.

❗ Current head db285a0 differs from pull request most recent head cc98c02. Consider uploading reports for the commit cc98c02 to get more accurate results

@@           Coverage Diff           @@
##           master   #6553    +/-   ##
=======================================
- Coverage      94%     92%    -2%     
=======================================
  Files         167     167            
  Lines       11166   11168     +2     
=======================================
- Hits        10538   10272   -266     
- Misses        628     896   +268     

[tchaton]

LGTM !

[kaushikb11]

Suggested change

	def deprecated(target: Callable, ver_deprecate: Optional[str] = "", ver_remove: Optional[str] = "") -> Callable:
	def deprecated(target: Callable, ver_deprecate: str = "", ver_remove: str = "") -> Callable:

Optional[...] references to Union[..., None]. Here, the default is "".