Custom Plugin is_distributed #6537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
requested review from
Borda,
SeanNaren,
carmocca and
tchaton
as code owners
SeanNaren
approved these changes
Mar 15, 2021
Contributor
SeanNaren
left a comment
SeanNaren
left a comment
There was a problem hiding this comment.
Good fix! in the future this should be how we determine if we're in distributed mode (via the plugin itself)
Closed
carmocca
approved these changes
Mar 15, 2021
justusschock
approved these changes
Mar 15, 2021
Collaborator
|
@carmocca @SeanNaren it is cool that all approve but how about checkboxes, milestone, or labels? |
Borda
reviewed
Mar 15, 2021
SeanNaren
pushed a commit
that referenced
this pull request
Mar 16, 2021
* return from plugin * dont return for tpu (cherry picked from commit 6a14146)
Borda
pushed a commit
that referenced
this pull request
Mar 16, 2021
* return from plugin * dont return for tpu (cherry picked from commit 6a14146)
lexierule
pushed a commit
that referenced
this pull request
Mar 16, 2021
* return from plugin * dont return for tpu (cherry picked from commit 6a14146)
This was referenced Mar 17, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for custom plugins to specify if they are distributed.
Fixes #6535
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃