Skip to content

Conversation

@awaelchli
Copy link
Contributor

What does this PR do?

Fixes #6465

This change let's the example run without error.
@tchaton is this fix correct? what kind of test do I need to add?

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added bug Something isn't working example labels Mar 14, 2021
@awaelchli awaelchli added this to the 1.2.x milestone Mar 14, 2021
@awaelchli awaelchli changed the title fix attribute access in toggle_optimizers fix attribute access in LightningModule.toggle_optimizer Mar 14, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @awaelchli. Yes, I should have set the default. Thanks for this PR !

@awaelchli awaelchli marked this pull request as ready for review March 14, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working example

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PPO examples in pl_examples/domain_templates/ not working

4 participants