Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 13, 2021

What does this PR do?

Change behaviors:

  1. CLI
  2. os env (in the case this is set by grid and not the user)
  3. trainer default

See also #6228

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working feature Is an improvement or enhancement priority: 0 High priority task labels Mar 13, 2021
@Borda Borda added this to the 1.2.x milestone Mar 13, 2021
@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #6510 (8dbccac) into master (6a14146) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6510    +/-   ##
=======================================
- Coverage      94%     93%    -2%     
=======================================
  Files         166     166            
  Lines       11276   11277     +1     
=======================================
- Hits        10617   10436   -181     
- Misses        659     841   +182     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda force-pushed the refactor/env-var-as-default branch from e44b5fc to 86b2659 Compare March 15, 2021 19:43
@Borda Borda marked this pull request as ready for review March 15, 2021 20:31
@Borda Borda enabled auto-merge (squash) March 15, 2021 20:34
@Borda Borda added the ready PRs ready to be merged label Mar 15, 2021
@carmocca carmocca disabled auto-merge March 15, 2021 20:47
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled auto-merge so you address my comment :)

@Borda Borda enabled auto-merge (squash) March 15, 2021 20:57
@Borda Borda force-pushed the refactor/env-var-as-default branch from 68fd035 to 78955ce Compare March 15, 2021 21:21
@Borda Borda mentioned this pull request Mar 15, 2021
@Borda Borda disabled auto-merge March 15, 2021 21:33
@Borda Borda enabled auto-merge (squash) March 15, 2021 21:36
@Borda Borda disabled auto-merge March 16, 2021 09:42
@Borda Borda enabled auto-merge (squash) March 16, 2021 09:42
@Borda Borda mentioned this pull request Mar 16, 2021
11 tasks
@Borda Borda merged commit 0f07eaf into master Mar 16, 2021
@Borda Borda deleted the refactor/env-var-as-default branch March 16, 2021 10:10
SeanNaren pushed a commit that referenced this pull request Mar 16, 2021
* change tests

* fix

* test

* _defaults_from_env_vars

Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit 0f07eaf)
Borda added a commit that referenced this pull request Mar 16, 2021
* change tests

* fix

* test

* _defaults_from_env_vars

Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit 0f07eaf)
lexierule pushed a commit that referenced this pull request Mar 16, 2021
* change tests

* fix

* test

* _defaults_from_env_vars

Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit 0f07eaf)
@carmocca carmocca mentioned this pull request Feb 17, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feature Is an improvement or enhancement priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants