-
Notifications
You must be signed in to change notification settings - Fork 3.6k
refactor reading env defaults #6510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6510 +/- ##
=======================================
- Coverage 94% 93% -2%
=======================================
Files 166 166
Lines 11276 11277 +1
=======================================
- Hits 10617 10436 -181
- Misses 659 841 +182 |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
e44b5fc to
86b2659
Compare
carmocca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabled auto-merge so you address my comment :)
Co-authored-by: Carlos Mocholí <[email protected]>
68fd035 to
78955ce
Compare
* change tests * fix * test * _defaults_from_env_vars Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit 0f07eaf)
* change tests * fix * test * _defaults_from_env_vars Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit 0f07eaf)
* change tests * fix * test * _defaults_from_env_vars Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit 0f07eaf)
What does this PR do?
Change behaviors:
See also #6228
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃