Skip to content

Conversation

@akihironitta
Copy link
Contributor

What does this PR do?

As pointed out in #6474, the docs still include the outdated order of zero_grad and backward which we changed in #6147.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the docs Documentation related label Mar 11, 2021
@akihironitta akihironitta added this to the 1.2.x milestone Mar 11, 2021
@carmocca carmocca added the ready PRs ready to be merged label Mar 11, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@tchaton tchaton enabled auto-merge (squash) March 12, 2021 08:31
@tchaton tchaton merged commit 680e83a into Lightning-AI:master Mar 12, 2021
@carmocca carmocca mentioned this pull request Mar 15, 2021
@akihironitta akihironitta deleted the docs/fix-zero_grad branch April 27, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants