Skip to content

Conversation

@kaushikb11
Copy link
Contributor

What does this PR do?

Hotfix for torchvision

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the ci Continuous Integration label Mar 11, 2021
@Borda
Copy link
Collaborator

Borda commented Mar 11, 2021

@kaushikb11 it seems to be still failing:

FAILED pl_examples/test_examples.py::test_examples_cpu[\n--default_root_dir %(tmpdir)s --max_epochs 1 --batch_size 32 --limit_train_batches 2 --limit_val_batches 2 -pl_examples.basic_examples.simple_image_classifier]
FAILED pl_examples/test_examples.py::test_examples_cpu[\n--default_root_dir %(tmpdir)s --max_epochs 1 --batch_size 32 --limit_train_batches 2 --limit_val_batches 2 -pl_examples.basic_examples.backbone_image_classifier]
FAILED pl_examples/test_examples.py::test_examples_cpu[\n--default_root_dir %(tmpdir)s --max_epochs 1 --batch_size 32 --limit_train_batches 2 --limit_val_batches 2 -pl_examples.basic_examples.autoencoder]

@Borda Borda changed the title Hotfix for torchvision Hotfix for torchvision [wip] Mar 11, 2021
@kaushikb11
Copy link
Contributor Author

@Borda Fixed.

@kaushikb11 kaushikb11 changed the title Hotfix for torchvision [wip] Hotfix for torchvision Mar 11, 2021
@kaushikb11 kaushikb11 merged commit 079fe9b into Lightning-AI:master Mar 11, 2021
@kaushikb11 kaushikb11 deleted the hot/fix branch March 11, 2021 11:19
@carmocca carmocca mentioned this pull request Mar 15, 2021
SeanNaren pushed a commit that referenced this pull request Mar 16, 2021
(cherry picked from commit 079fe9b)
lexierule pushed a commit that referenced this pull request Mar 16, 2021
(cherry picked from commit 079fe9b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants