Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Mar 11, 2021

What does this PR do?

Removes an obsolete todo about a crashing example, but the example runs fine:

trainer.test(model, datamodule=dm)
and
trainer.test(datamodule=dm)

both work fine after running fit for 1 epoch.
I could not observer any error message described by the todo.

Epoch 0:  92%|█████████▏| 1718/1874 [00:06<00:00, 257.13it/s, loss=0.353, v_num=2]
Validating: 0it [00:00, ?it/s]
Epoch 0:  94%|█████████▍| 1762/1874 [00:06<00:00, 259.86it/s, loss=0.353, v_num=2]
Epoch 0:  96%|█████████▋| 1808/1874 [00:06<00:00, 262.70it/s, loss=0.353, v_num=2]
Validating:  58%|█████▊    | 90/156 [00:00<00:00, 444.70it/s]
Epoch 0: 100%|██████████| 1874/1874 [00:07<00:00, 266.29it/s, loss=0.353, v_num=2]
Epoch 0: 100%|██████████| 1874/1874 [00:07<00:00, 266.10it/s, loss=0.353, v_num=2]
Testing: 100%|██████████| 312/312 [00:00<00:00, 418.23it/s]
--------------------------------------------------------------------------------
DATALOADER:0 TEST RESULTS
{'test_loss': 0.357555627822876}
--------------------------------------------------------------------------------
[{'test_loss': 0.357555627822876}]

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #6475 (0f2207a) into master (9eded7f) will decrease coverage by 47%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #6475     +/-   ##
========================================
- Coverage      94%     47%    -47%     
========================================
  Files         161     161             
  Lines       11497   11835    +338     
========================================
- Hits        10753    5508   -5245     
- Misses        744    6327   +5583     

@awaelchli awaelchli merged commit 62d4304 into master Mar 11, 2021
@awaelchli awaelchli deleted the docs/obsolete-example-todo branch March 11, 2021 17:49
@carmocca carmocca mentioned this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related example

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants