Skip to content

Conversation

@s-rog
Copy link
Contributor

@s-rog s-rog commented Mar 9, 2021

What does this PR do?

add test for #4688
(should have included this with 4688, apologies)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@s-rog s-rog changed the title init test: test_lr_find_with_bs_scale [test] lr_find with bs_scale Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #6422 (6014111) into master (523c59b) will decrease coverage by 2%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6422    +/-   ##
=======================================
- Coverage      94%     92%    -2%     
=======================================
  Files         161     161            
  Lines       11497   11390   -107     
=======================================
- Hits        10753   10426   -327     
- Misses        744     964   +220     

@s-rog s-rog added this to the 1.2.x milestone Mar 9, 2021
@s-rog s-rog added the ci Continuous Integration label Mar 9, 2021
@s-rog s-rog self-assigned this Mar 9, 2021
@s-rog s-rog marked this pull request as ready for review March 9, 2021 01:34
@pep8speaks
Copy link

pep8speaks commented Mar 9, 2021

Hello @s-rog! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-12 01:22:30 UTC

@s-rog s-rog requested a review from carmocca March 9, 2021 05:15
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@s-rog s-rog enabled auto-merge (squash) March 12, 2021 01:53
@s-rog s-rog added the ready PRs ready to be merged label Mar 12, 2021
@s-rog s-rog merged commit c48fc6a into master Mar 15, 2021
@s-rog s-rog deleted the tests/lr_find_test branch March 15, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants