-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add check for verbose attribute of ModelCheckpoint #6419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the test_model_checkpoint_save_last_warning tests by ensuring that verbose is set for them. You can parameterize verbose for the test to ensure that the warnings are not logged after your change
Codecov Report
@@ Coverage Diff @@
## master #6419 +/- ##
=======================================
- Coverage 94% 92% -2%
=======================================
Files 161 161
Lines 11497 11497
=======================================
- Hits 10753 10532 -221
- Misses 744 965 +221 |
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Co-authored-by: Adrian Wälchli <[email protected]>
What does this PR do?
Fixes #6408
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃