Skip to content

Conversation

@ashleve
Copy link
Contributor

@ashleve ashleve commented Mar 8, 2021

What does this PR do?

Fixes #6408

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the test_model_checkpoint_save_last_warning tests by ensuring that verbose is set for them. You can parameterize verbose for the test to ensure that the warnings are not logged after your change

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #6419 (a200428) into master (e1f5eac) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6419    +/-   ##
=======================================
- Coverage      94%     92%    -2%     
=======================================
  Files         161     161            
  Lines       11497   11497            
=======================================
- Hits        10753   10532   -221     
- Misses        744     965   +221     

@ashleve ashleve requested a review from ananthsub March 8, 2021 21:48
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@awaelchli awaelchli added feature Is an improvement or enhancement checkpointing Related to checkpointing labels Mar 8, 2021
@awaelchli awaelchli added this to the 1.3 milestone Mar 8, 2021
@carmocca carmocca merged commit 9eded7f into Lightning-AI:master Mar 8, 2021
@carmocca carmocca mentioned this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

checkpointing Related to checkpointing feature Is an improvement or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make verbose=False prevent showing "Saving latest checkpoint..."

4 participants