Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 8, 2021

What does this PR do?

Opening PR to run tests, let's see...
Looks like not an issue anymore

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the ci Continuous Integration label Mar 8, 2021
@carmocca carmocca self-assigned this Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #6402 (eab5525) into master (a6c98c4) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6402   +/-   ##
======================================
- Coverage      94%     94%   -0%     
======================================
  Files         161     161           
  Lines       11488   11488           
======================================
- Hits        10748   10747    -1     
- Misses        740     741    +1     

@carmocca carmocca marked this pull request as ready for review March 8, 2021 03:23
@awaelchli awaelchli added the ready PRs ready to be merged label Mar 8, 2021
@Borda
Copy link
Collaborator

Borda commented Mar 8, 2021

seems it was really just some random CI failer...

@Borda Borda merged commit 8dabc30 into master Mar 8, 2021
@Borda Borda deleted the resolve-flake8-todo branch March 8, 2021 07:12
@carmocca carmocca mentioned this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants