Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 6, 2021

What does this PR do?

Fixes #4945 (comment)

This has the advantage of allowing people to inspect the definition, but without adding useless attributes

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the docs Documentation related label Mar 6, 2021
@carmocca carmocca added this to the 1.3 milestone Mar 6, 2021
@carmocca carmocca self-assigned this Mar 6, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 6, 2021

Hello @carmocca! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-06 13:32:31 UTC

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome idea !

@tchaton tchaton enabled auto-merge (squash) March 6, 2021 13:30
@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #6377 (7b0fcd7) into master (d0596fa) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6377    +/-   ##
=======================================
- Coverage      94%     92%    -2%     
=======================================
  Files         161     161            
  Lines       11479   11480     +1     
=======================================
- Hits        10735   10516   -219     
- Misses        744     964   +220     

@tchaton tchaton merged commit 217470b into master Mar 6, 2021
@tchaton tchaton deleted the trainer-fit-doc branch March 6, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants