Skip to content

Conversation

@kaushikb11
Copy link
Contributor

What does this PR do?

Update changelog for v1.2.2

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added the ready PRs ready to be merged label Mar 3, 2021
@Borda Borda changed the title Update changelog for v1.2.2 [blocked by #6304] Update changelog for v1.2.2 Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #6325 (42bf282) into master (46540ee) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6325   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files         161     161           
  Lines       11457   11457           
======================================
  Hits        10481   10481           
  Misses        976     976           

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the has conflicts label Mar 5, 2021
@Borda Borda changed the title [blocked by #6304] Update changelog for v1.2.2 Update changelog for v1.2.2 Mar 5, 2021
@Borda Borda force-pushed the update/changelog branch from a356d09 to e5b7cc4 Compare March 5, 2021 15:33
@mergify mergify bot removed the has conflicts label Mar 5, 2021
@Borda Borda enabled auto-merge (squash) March 5, 2021 15:34
@Borda Borda merged commit b6aa350 into Lightning-AI:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants