Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 2, 2021

What does this PR do?

after update #6211 let's try unfreeze torchtext version
see: #3529 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Mar 2, 2021
@Borda Borda added this to the 1.2.x milestone Mar 2, 2021
@Borda Borda enabled auto-merge (squash) March 2, 2021 14:38
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #6302 (0c415ff) into master (8001987) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6302   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         160     160           
  Lines       11397   11397           
======================================
- Hits        10638   10609   -29     
- Misses        759     788   +29     

@Borda Borda added the ready PRs ready to be merged label Mar 2, 2021
@Borda
Copy link
Collaborator Author

Borda commented Mar 2, 2021

Docker failer is unrelated as it fails on miss-versions requested/downloaded 1.6 or nightly but always got 1.7.1 only
cc: @zcain117

#12 0.988 torch                     1.7.1
#12 0.988 torch-xla                 1.9+c865714

https://github.com/PyTorchLightning/pytorch-lightning/pull/6302/checks?check_run_id=2014014414#step:4:2272

@Borda Borda added the priority: 1 Medium priority task label Mar 2, 2021
@Borda Borda merged commit 38274b9 into master Mar 2, 2021
@Borda Borda deleted the ci/torchtext branch March 2, 2021 15:38
@tchaton tchaton mentioned this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants