Skip to content

Conversation

@akihironitta
Copy link
Contributor

What does this PR do?

Removes optimizer arg from manual_backward in the docs.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #6267 (111295a) into master (352e8f0) will decrease coverage by 2%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6267    +/-   ##
=======================================
- Coverage      93%     91%    -2%     
=======================================
  Files         159     159            
  Lines       11362   11362            
=======================================
- Hits        10605   10335   -270     
- Misses        757    1027   +270     

@Borda Borda added the docs Documentation related label Mar 1, 2021
@Borda Borda added this to the 1.3 milestone Mar 1, 2021
@Borda Borda enabled auto-merge (squash) March 1, 2021 17:42
@Borda Borda added the ready PRs ready to be merged label Mar 1, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit 412a7d8 into Lightning-AI:master Mar 1, 2021
maxfrei750 pushed a commit to maxfrei750/pytorch-lightning that referenced this pull request Mar 1, 2021
@tchaton tchaton modified the milestones: 1.3, 1.2.x Mar 2, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Mar 2, 2021
@kaushikb11 kaushikb11 mentioned this pull request Mar 2, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Mar 2, 2021
s-rog pushed a commit that referenced this pull request Mar 11, 2021
…es. (#6277)

* cleaning SWA (#6259)

* rename

* if

* test

* chlog

* Remove opt from manual_backward in docs (#6267)

* switch agents pool (#6270)

* Allow user to disable the automatic formatting of checkpoint file names.

* Added changelog entry.

* Made flake8 happy.

* Applied review suggestion: quotes for special characters in docstring

Co-authored-by: Carlos Mocholí <[email protected]>

* Fixed example in docstring.

* Fixed syntax error in docstring.

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants