-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Disable CPU Offload as default for DeepSpeed #6262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6262 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 159 159
Lines 11365 11365
======================================
- Hits 10608 10579 -29
- Misses 757 786 +29 |
Closed
carmocca
approved these changes
Mar 1, 2021
Borda
approved these changes
Mar 1, 2021
awaelchli
approved these changes
Mar 2, 2021
ananthsub
approved these changes
Mar 2, 2021
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Mar 2, 2021
* Change default for CPU offload to false for best throughput/memory efficiency * Add changelog * default Co-authored-by: Jirka Borovec <[email protected]>
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Mar 2, 2021
* Change default for CPU offload to false for best throughput/memory efficiency * Add changelog * default Co-authored-by: Jirka Borovec <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Mar 5, 2021
* Change default for CPU offload to false for best throughput/memory efficiency * Add changelog * default Co-authored-by: Jirka Borovec <[email protected]>
This was referenced Mar 12, 2021
Closed
Closed
[tune](deps): Bump pytorch-lightning from 1.0.3 to 1.2.3 in /python/requirements
sumanthratna/ray#12
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd party
Related to a 3rd-party
bug
Something isn't working
distributed
Generic distributed-related topic
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I've had a few reports that the default for DeepSpeed is incredibly slow and is unusable. After investigation, this is because CPU offload by default is set to True, and this can be prohibitive when running DeepSpeed. Instead we should turn off CPU offload, and keep ZeRO on allowing the user to use CPU Offload if necessary.
This can also been seen from the benchmarks here: https://github.com/SeanNaren/minGPT#ddp-vs-deepspeed
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃