Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 1, 2021

What does this PR do?

followup for #5920 as it was merged to early

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Mar 1, 2021
@mergify mergify bot added the has conflicts label Mar 1, 2021
@Borda Borda requested review from a team, kaushikb11, rohitgr7, s-rog and tullie March 1, 2021 12:33
@mergify mergify bot removed the has conflicts label Mar 1, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #6258 (c17ea57) into master (58a6d59) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #6258   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         159     159           
  Lines       11360   11360           
======================================
- Hits        10606   10574   -32     
- Misses        754     786   +32     

@Borda Borda requested a review from carmocca March 1, 2021 12:58
@Borda Borda added the ready PRs ready to be merged label Mar 1, 2021
@Borda Borda requested a review from kaushikb11 March 1, 2021 13:49
Copy link
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner :]

@Borda
Copy link
Collaborator Author

Borda commented Mar 1, 2021

Looks much cleaner :]

well done by @carmocca

@Borda Borda merged commit 352e8f0 into master Mar 1, 2021
@Borda Borda deleted the tests/skipif branch March 1, 2021 15:26
@tchaton tchaton added this to the 1.2.x milestone Mar 2, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants