Temporary fix to be BC compatible with torchtext #6168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagocrepaldi
requested review from
Borda,
SeanNaren,
carmocca and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6168 +/- ##
========================================
- Coverage 91% 46% -45%
========================================
Files 160 160
Lines 11435 11323 -112
========================================
- Hits 10446 5260 -5186
- Misses 989 6063 +5074 |
tchaton
approved these changes
Feb 25, 2021
carmocca
reviewed
Feb 25, 2021
Contributor
carmocca
left a comment
carmocca
left a comment
There was a problem hiding this comment.
Until PyTorch Lightning can use the new API
What's blocking it?
Can you look at the failing tests?
Author
It seems the CI VMs are using older |
Collaborator
it is expected, see min requirements |
Collaborator
|
seems to be duplicate to #6211 |
Borda
added
bug
tiborkiss
added a commit
to tiborkiss/NeMo
that referenced
this pull request
Mar 9, 2021
tiborkiss
added a commit
to tiborkiss/NeMo
that referenced
this pull request
Mar 9, 2021
… pull down 1.8.0. Lightning-AI/pytorch-lightning#6168 Signed-off-by: Tibor Kiss <[email protected]>
tiborkiss
added a commit
to tiborkiss/NeMo
that referenced
this pull request
Mar 13, 2021
… pull down 1.8.0. Lightning-AI/pytorch-lightning#6168 Signed-off-by: Tibor Kiss <[email protected]>
tiborkiss
added a commit
to tiborkiss/NeMo
that referenced
this pull request
Mar 15, 2021
… pull down 1.8.0. Lightning-AI/pytorch-lightning#6168 Signed-off-by: Tibor Kiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
torchtext.data.Batchwas deprecated (and moved totorchtext.legacy.data.Batch, which breaks PyTorch LightningUntil PyTorch Lightning can use the new API, it should use the legacy version to allow PyTorch nightly (torch, torchtext) users to keep using PyTorch lightning during development
Fixes #6165