Add mypy typing to precision plugins. #6149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusschock
requested review from
Borda,
SeanNaren,
awaelchli,
carmocca,
tchaton and
williamFalcon
as code owners
Borda
approved these changes
Feb 23, 2021
| def backward( | ||
| self, | ||
| lightning_module: LightningModule, | ||
| model: 'LightningModule', |
Member
Author
There was a problem hiding this comment.
It was named model in all the other plugins and I checked, It is never called by name.
But if we don't do this, MypY complains, that the signature does not match with base class since it has different parameters
pytorch_lightning/plugins/training_type/training_type_plugin.py
Outdated
Show resolved
Hide resolved
Borda
reviewed
Feb 23, 2021
Borda
reviewed
Feb 23, 2021
Co-authored-by: Akihiro Nitta <[email protected]>
justusschock
force-pushed
the
typing_precision_plugins
branch
from
06355f4 to
249563c
Compare
Codecov Report
@@ Coverage Diff @@
## master #6149 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 159 159
Lines 11381 11381
======================================
- Hits 10626 10597 -29
- Misses 755 784 +29 |
awaelchli
changed the title
awaelchli
approved these changes
Feb 25, 2021
| class NativeMixedPrecisionPlugin(MixedPrecisionPlugin): | ||
|
|
||
| def __init__(self): | ||
| def __init__(self) -> None: |
Contributor
There was a problem hiding this comment.
why is it necessary to annotate init with None?
Contributor
There was a problem hiding this comment.
akihironitta
approved these changes
Feb 26, 2021
carmocca
approved these changes
Feb 26, 2021
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Mar 2, 2021
Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR should be merged after #6148
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃