Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Feb 22, 2021

What does this PR do?

Some small doc fixes to be more specific when to use DeepSpeed.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the docs Documentation related label Feb 22, 2021
@SeanNaren SeanNaren self-assigned this Feb 22, 2021
@SeanNaren SeanNaren requested a review from carmocca February 22, 2021 22:04
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #6142 (09967e1) into master (0456b45) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6142   +/-   ##
======================================
- Coverage      91%     91%   -0%     
======================================
  Files         160     160           
  Lines       11423   11423           
======================================
- Hits        10434   10405   -29     
- Misses        989    1018   +29     

@Borda Borda enabled auto-merge (squash) February 22, 2021 22:35
@Borda Borda added the ready PRs ready to be merged label Feb 22, 2021
@Borda Borda merged commit 863a70c into master Feb 22, 2021
@Borda Borda deleted the docs/deepspeed_refresh branch February 22, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants