Disable batch transfer in DP mode #6098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6098 +/- ##
======================================
- Coverage 94% 94% -0%
======================================
Files 161 161
Lines 11516 11485 -31
======================================
- Hits 10775 10741 -34
- Misses 741 744 +3 |
rohitgr7
force-pushed
the
bugfix/dp_batch_transfer
branch
from
4c8a09d to
3ad5e86
Compare
rohitgr7
requested review from
Borda,
SeanNaren,
awaelchli,
carmocca,
tchaton and
williamFalcon
as code owners
carmocca
reviewed
Feb 21, 2021
rohitgr7
commented
Feb 22, 2021
carmocca
approved these changes
Feb 22, 2021
Borda
approved these changes
Feb 22, 2021
rohitgr7
changed the title
rohitgr7
changed the title
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: chaton <[email protected]>
Borda
force-pushed
the
bugfix/dp_batch_transfer
branch
from
95b9e87 to
8c7c85a
Compare
|
Hello @rohitgr7! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-11 15:22:41 UTC |
Closed
SeanNaren
pushed a commit
that referenced
this pull request
Mar 16, 2021
* add exceptions and test * hook * fix * clean up * clean up * regex * regex * docs * rev * comment and docs * chlog * Apply suggestions from code review Co-authored-by: Carlos Mocholí <[email protected]> * Apply suggestions from code review Co-authored-by: chaton <[email protected]> * Monkey-patch device count * docs * pep * api_change Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: chaton <[email protected]> (cherry picked from commit c53edce)
lexierule
pushed a commit
that referenced
this pull request
Mar 16, 2021
* add exceptions and test * hook * fix * clean up * clean up * regex * regex * docs * rev * comment and docs * chlog * Apply suggestions from code review Co-authored-by: Carlos Mocholí <[email protected]> * Apply suggestions from code review Co-authored-by: chaton <[email protected]> * Monkey-patch device count * docs * pep * api_change Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: chaton <[email protected]> (cherry picked from commit c53edce)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is no need to transfer the batch to the device in DP mode since it's handled internally. Else what's happening now is let say a batch with batch_size 32 is there. Then first it's transferred to gpu:0, passed to the model wrapped around DataParallel and again transferred to separate devices after splitting. So the first transfer is unnecessary.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃